Re: Patch for PGunescapeBytea

From: Ben Lamb <pgsql-patches(at)zurgy(dot)org>
To: "Magnus Naeslund(f)" <mag(at)fbab(dot)net>, <pgsql-patches(at)postgresql(dot)org>
Cc: "Billy G(dot) Allie" <bill(dot)allie(at)mug(dot)org>
Subject: Re: Patch for PGunescapeBytea
Date: 2003-05-05 17:59:43
Message-ID: 200305051859.43663.pgsql-patches@zurgy.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Monday 05 May 2003 5:45 pm, Magnus Naeslund(f) wrote:
> I think these lines:
>
> buffer = realloc(buffer, buflen);
> ---
> if (buffer == NULL)
> return NULL;
> ---
>
> are wrong. Shouldn't one do:
> ---
> tmpbuf=realloc(buf,...);
> if (!tmpbuf)
> free(buf), return 0;
> ---

Thanks for pointing this out, do I need to send an updated patch to the list?

Ben.

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Manfred Koizar 2003-05-05 23:07:35 Re: Simple LRU for clog and (later) subtrans
Previous Message Magnus Naeslund(f) 2003-05-05 16:45:59 Re: Patch for PGunescapeBytea