Re: [PERFORM] Foreign key performance

On Sat, 19 Apr 2003, Tom Lane wrote:

> Stephan Szabo <sszabo(at)megazone23(dot)bigpanda(dot)com> writes:
> > The hack was just the keeping around the list pointer from the last run
> > through (see attached - passed simple fk tests and regression, but there
> > might be problems I don't see).
>
> Shouldn't this patch update the comment in deferredTriggerInvokeEvents
> (c. line 1860 in cvs tip)?

Probably, since the second part of that is basically what this is. I'll
update and send updated patch tomorrow.

> > Looking at the code, I also wonder if we
> > would get some gain by not allocating the per_tuple_context at the
> > beginning but only when a non-deferred constraint is found since otherwise
> > we're creating and destroying the context and possibly never using it.
>
> I doubt it's worth worrying over. Creation/destruction of a never-used
> memory context is pretty cheap, I think.

Okay, sounds good enough for me. :)