Re: [HACKERS] psql and readline

From: Patrick Welche <prlw1(at)newn(dot)cam(dot)ac(dot)uk>
To: "Ross J(dot) Reedstrom" <reedstrm(at)rice(dot)edu>
Cc: pgsql-patches(at)postgresql(dot)org, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Subject: Re: [HACKERS] psql and readline
Date: 2003-02-16 18:04:50
Message-ID: 20030216180450.C4454@quartz.newn.cam.ac.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Sat, Feb 15, 2003 at 08:29:12PM -0600, Ross J. Reedstrom wrote:
> Here's the patch I promised over on HACKERS - it alters the implementation
> of '\e' history tracking for systems that have a readline compatability
> library without replace_history_entry. I fall back to pushing the query
> onto the history stack after the \e, rather than replacing it.
>
> The patch adds one more place to look for readline headers, and a test
> for replace_history_entry. I've only included the patch for configure.in -
> I presume configure in CVS is generated on the central server? (I've got
> autoconf 2.54 installed, the file in CVS was generated by 2.53 - there are
> a number of diffs other than those caused by my additions to configure.in)
>
> Patrick, does this patch work for you, in your build environment?

checking for readline... yes (-ledit -lcurses)
...
checking readline/readline.h usability... yes
checking readline/readline.h presence... yes
checking for readline/readline.h... yes
checking readline/history.h usability... yes
checking readline/history.h presence... yes
checking for readline/history.h... yes
...
checking for rl_completion_append_character... yes
checking for rl_completion_matches... no
checking for rl_filename_completion_function... no
checking for replace_history_entry... no

and cursor up gets me the previous command, \e edits it, and another
cursor up gets me the command as edited, so all OK !

Thank you!

Patrick

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2003-02-16 19:26:24 Re: stats_command_string default?
Previous Message Kevin Brown 2003-02-16 08:45:22 Re: stats_command_string default?