Re: psql and readline

From: Patrick Welche <prlw1(at)newn(dot)cam(dot)ac(dot)uk>
To: "Ross J(dot) Reedstrom" <reedstrm(at)ece(dot)rice(dot)edu>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Peter Mount <peter(at)retep(dot)org(dot)uk>, Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: psql and readline
Date: 2003-02-16 17:29:34
Message-ID: 20030216172934.A4454@quartz.newn.cam.ac.uk
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Feb 15, 2003 at 03:10:19PM -0600, Ross J. Reedstrom wrote:
> On Fri, Feb 14, 2003 at 11:32:02AM -0500, Tom Lane wrote:
> > Patrick Welche <prlw1(at)newn(dot)cam(dot)ac(dot)uk> writes:
> > > On Thu, Feb 13, 2003 at 10:25:52AM -0500, Tom Lane wrote:
> > >> Well, is that a bug in your wrapper? Or must we add a configure test
> > >> for the presence of replace_history_entry()?
> >
> > > Good question. Easiest for now for me would be add a configure test.
> >
> > Okay with me --- Ross, can you handle that?
>
> I'll take a crack at it. Testing will be a problem, since all my machines
> have libreadline installed, but I've got one I can probably pull it off
> of. Patrick, is 'your libedit wrapper' your personal code, or something
> standard on some set of systems (e.g. *BSD) ?

It's the standard NetBSD libedit which comes with built-in readline emulation,
it's just that replace_history_entry isn't one of the emulated functions.
({read,write,add}_history() are included)

> Ross "one line patches always grow" Reedstrom

:-)

I'm of course very happy to test the growing patch!

Cheers,

Patrick

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2003-02-16 17:45:08 Re: client_encoding directive is ignored in
Previous Message Greg Stark 2003-02-16 15:00:40 online reindex