Re: contrib/earthdistance missing regression test files

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Bruno Wolff III <bruno(at)wolff(dot)to>
Cc: Joe Conway <mail(at)joeconway(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: contrib/earthdistance missing regression test files
Date: 2002-09-24 21:03:22
Message-ID: 200209242103.g8OL3Mm11501@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruno Wolff III wrote:
> On Tue, Sep 24, 2002 at 16:10:19 -0400,
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> wrote:
> > Bruno Wolff III wrote:
> > > On Tue, Sep 24, 2002 at 15:02:20 -0500,
> > > Bruno Wolff III <bruno(at)wolff(dot)to> wrote:
> > > >
> > > > There is supposed to be a regression test. I may have forgotten to use
> > > > -N or -r on the diff. If it is confirmed that the files needed for the
> > > > regression test didn't make it into the submitted diff file, I can send
> > > > in a diff versus current cvs.
> > >
> > > I still have a copy of the diff file (at least I think it is the one I
> > > sent in) and it has the regression sql and output files defined.
> >
> > Yep, I missed adding earthdistance.out. Is that the only file.
>
> No. The new files are:
> expected/earthdistance.out (which you metion above)
> sql/earthdistance.sql

OK, here's what I see now in CVS:

#$ pwd
/pgtop/contrib/earthdistance
#$ lf
CVS/ README.earthdistance earthdistance.out
Makefile earthdistance.c earthdistance.sql.in

What should be changed?

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Hannu Krosing 2002-09-24 21:12:14 Re: DROP COLUMN misbehaviour with multiple inheritance
Previous Message Bruno Wolff III 2002-09-24 20:41:32 Re: contrib/earthdistance missing regression test files