Re: DROP COLUMN misbehaviour with multiple inheritance

From: Alvaro Herrera <alvherre(at)atentus(dot)com>
To: Hannu Krosing <hannu(at)tm(dot)ee>
Cc: tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)postgresql(dot)org
Subject: Re: DROP COLUMN misbehaviour with multiple inheritance
Date: 2002-09-13 02:52:40
Message-ID: 20020912225240.699808bc.alvherre@atentus.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

En 12 Sep 2002 17:23:41 +0200
Hannu Krosing <hannu(at)tm(dot)ee> escribió:

> The other sad thing about the current behaviour is that in addition to
> being wrong it also breaks dump/reload - after dump/reload the initially
> dropped column is back in c1.

I hadn't read this paragraph before. But I don't understand what
you're saying. If I drop the column from p1 but not from p2, how is it
expected that the column doesn't show in c1, that inherits both? Truth
is that the column shouldn't have disappeared in the first place, so it
isn't a mistake that shows up in the dump.

Sure, databases before and after the dump are different, but the one
before dump is broken. I don't have the original pgsql version (without
the patch) compiled right now, but I think that if you were to select
from p2, the backend would crash (or at least elog(ERROR)).

Anyway, the patch I just submitted should fix this bug. Please test it
and thanks for the report.

--
Alvaro Herrera (<alvherre[a]atentus.com>)
"La conclusion que podemos sacar de esos estudios es que
no podemos sacar ninguna conclusion de ellos" (Tanenbaum)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2002-09-13 03:27:08 Re: OPAQUE and 7.2-7.3 upgrade
Previous Message Alvaro Herrera 2002-09-13 02:13:15 Re: [HACKERS] DROP COLUMN misbehaviour with multiple inheritance

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2002-09-13 03:40:21 Re: DROP COLUMN misbehaviour with multiple inheritance
Previous Message Alvaro Herrera 2002-09-13 02:13:15 Re: [HACKERS] DROP COLUMN misbehaviour with multiple inheritance