| From: | nconway(at)klamath(dot)dyndns(dot)org (Neil Conway) |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: default attstattarget |
| Date: | 2002-07-20 18:19:11 |
| Message-ID: | 20020720181911.GA28160@klamath.dyndns.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
On Sat, Jul 20, 2002 at 01:18:22AM -0400, Tom Lane wrote:
> I'm unexcited about the proposed gram.y changes, especially since you
> didn't document them. I do not think we need a SET DEFAULT variant;
> anyone bright enough to be toying with attstattarget at all can figure
> out how to revert it to -1 if they want.
I'm indifferent about SET DEFAULT, so I removed it.
> Otherwise it looks reasonable ...
Thanks for the code review.
A revised patch incorporating Tom's suggestions is attached.
Cheers,
Neil
--
Neil Conway <neilconway(at)rogers(dot)com>
PGP Key ID: DB3C29FC
| Attachment | Content-Type | Size |
|---|---|---|
| attstat-4.patch | text/plain | 31.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Manfred Koizar | 2002-07-20 18:40:42 | More heap tuple header fixes |
| Previous Message | Tom Lane | 2002-07-20 16:19:37 | Re: pgsql/ oc/src/sgml/release.sgml rc/backend/com ... |