Re: CLUSTER patch

Alvaro Herrera wrote:
> Tom Lane dijo:
>
> > Alvaro Herrera <alvherre(at)atentus(dot)com> writes:
> > > It does indeed work. Actually, I tried to do that before, but the fact
> > > that RelationFlushBuffers requires a firstDelBlock made me turn around.
> >
> > firstDelBlock should be 0, not length-of-relation; as given, this code
> > fails to get rid of the buffer entries!
>
> Oh, I failed to understand completely the purpose of firstDelBlock then.
>
> Anyway, there's still a big problem with this patch: the pg_depend
> information gets messed up after CLUSTER, so a clustered table cannot be
> dropped. I don't know why is this.

I actually backed out Tom's recent change to cluster.c (attached),
applied your patch, then manually applied Tom's patch to cluster.c so I
had a working version of your patch with the new dependencies. Seemed
to work fine. I will do the same when I apply you version.

> As I said yesterday, I'm going on vacation tomorrow, and probably will
> not fix this issue. I can look into it when I'm back, on two weeks.

I will take care of applying your patch and the doc part too. It will
be all done when you return. Thanks for your work and have a nice
vacation.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026