Re: [SQL] pg_restore cannot restore function

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jie Liang <jie(at)stbernard(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [SQL] pg_restore cannot restore function
Date: 2002-07-04 05:36:09
Message-ID: 200207040536.g645a9301288@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches pgsql-sql

Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > The following patch fixes all of these, and it will be in 7.3.
>
> It will? Kindly explain what the heck this is doing. It looks to
> me like it will probably break more cases than it fixes. AFAICS
> it's just completely muddying the waters about what is quoted and
> what isn't ...

Well, the waters were already muddy. Doing a pg_dump -Ft, you will see
with the old code how the tags for functions had quotes, and how the
GRANT/REVOKE has quotes for table names, while the CREATE TABLE tags for
these do not. This fixes that, and tries to get the -P string they
enter for pg_restore to match the tag by removing spaces.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Dave Page 2002-07-04 09:02:30 Re: [ODBC] UI patch (Was: ODBC Patch to prevent setting of KSQO on 7.3+ servers)
Previous Message Tom Lane 2002-07-04 05:33:57 Re: [SQL] pg_restore cannot restore function

Browse pgsql-sql by date

  From Date Subject
Next Message srikanth 2002-07-04 10:45:00 how to write procedures
Previous Message Tom Lane 2002-07-04 05:33:57 Re: [SQL] pg_restore cannot restore function