Re: Operator Comments

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Mike Mascari <mascarm(at)mascari(dot)com>
Cc: Rod Taylor <rbt(at)zort(dot)ca>, Dave Page <dpage(at)vale-housing(dot)co(dot)uk>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Operator Comments
Date: 2002-06-05 20:00:10
Message-ID: 200206052000.g55K0AF14888@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Mike Mascari wrote:
> Here's the history, FWIW:
>
> I implemented COMMENT ON for just TABLES and COLUMNS, like Oracle.
>
> Bruce requested it for all objects
>
> I extended for all objects - including databases (my bad) ;-)
>
> Peter E. was rewriting psql and wanted the COMMENT on operators to
> reflect a COMMENT on the underlying function
>
> I submitted a patch to do that - I just do what I'm told ;-)

Actually, the use of function comments for operators goes back to when I
added comments to system tables in include/catalog. I wanted to avoid
duplication of comments so I placed them only on the functions and let
the operators display the function comments. Were there cases where we
don't want the function comments for certain operators? I never
anticipated that.

Anyway, I looked at the new psql code and it works fine, tries
pg_operator description first, then pg_proc if missing.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2002-06-05 20:05:02 Re: Roadmap for a Win32 port
Previous Message Igor Kovalenko 2002-06-05 19:32:13 Re: Roadmap for a Win32 port