Re: regexp character class locale awareness patch

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Manuel Sugawara <masm(at)fciencias(dot)unam(dot)mx>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: regexp character class locale awareness patch
Date: 2002-04-16 23:21:50
Message-ID: 200204162321.g3GNLoU24802@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Manuel Sugawara wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> >
> > Basically, you manually preprocess the patch to include the
> > USE_LOCALE branch and remove the not USE_LOCALE branch.
>
> Yeah, that should work. You may also remove include/regex/cclass.h
> since it will not be used any more.
>
> > However, if the no-locale branches have significant performance
> > benefits then it might be worth pondering setting up some
> > optimizations.
>
> This is not the case.

Here is a patch based on this discussion.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

Attachment Content-Type Size
unknown_filename text/plain 3.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2002-04-16 23:34:17 Re: [PATCHES] WITH DELIMITERS in COPY
Previous Message Tom Lane 2002-04-16 23:19:30 Re: [HACKERS] Foreign Key woes -- 7.2 and ~7.3