Neil Conway wrote:
> On Fri, Mar 08, 2002 at 11:07:57AM -0500, Bruce Momjian wrote:
> > Tom Lane wrote:
> > > Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > > > This is possible because btree is the default. TODO item is:
> > > > * Remove USING clause from pg_get_indexdef() if index is btree (Bruce)
> > >
> > > I do not think this is necessary or helpful. The only possible
> > > reason to change it would be if we thought btree might someday
> > > not be the default index type --- but no such change is on the
> > > horizon. And if one was, you've just embedded special knowledge
> > > about btree in yet one more place...
> >
> > Yes, but it doesn't look like the way they created it.
>
> Why is this relevant?
>
> > Very few use
> > USING in there queries. Why show it in pg_dump output?
>
> I agree with Tom: this seems like a waste of time, and may even be worse
> than the current pg_dump output. The type of the index is "btree"; by
> assuming that Pg happens to default to "btree", you're just making the
> process of index restoration more fragile.
OK, how about this patch? It just creates a macro so btree is a clear
default. It no longer affects pg_dump.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026