From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Neil Conway <nconway(at)klamath(dot)dyndns(dot)org> |
Cc: | pgsql-patches(at)postgresql(dot)org |
Subject: | Re: [PATCH] GiST code cleanup |
Date: | 2002-03-05 05:31:30 |
Message-ID: | 200203050531.g255VUD15710@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Patch applied. I checked the other interfaces and this fits with their
interfaces. I modified rtree to match the new gist adjuststack() call.
---------------------------------------------------------------------------
Neil Conway wrote:
> Hi all,
>
> I was digging through the GiST code, and figured I'd fix up some of the
> "bad smell" in that code. Stuff like function parameters that aren't
> used, typos in the comments, comparison between signed and unsigned
> ints, etc.
>
> Attached is a pretty trivial patch; it compiles, but beyond that
> completely untested. Unless anyone sees any problems, please apply for
> 7.3.
>
> Comments would be appreciated: is this kind of janitorial work welcome?
>
> Cheers,
>
> Neil
>
> --
> Neil Conway <neilconway(at)rogers(dot)com>
> PGP Key ID: DB3C29FC
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2002-03-05 05:32:46 | Re: TOAST-slicing: substring access methods for TOASTed values. |
Previous Message | Bruce Momjian | 2002-03-05 05:20:27 | Re: Fix for non-blocking connections in libpq |