| From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Undocumented feature costs a lot of performance in COPY |
| Date: | 2001-12-04 20:07:01 |
| Message-ID: | 200112042007.fB4K72327600@candle.pha.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
> I would like to change the code to just "if (c == delim[0])",
> which should buy back most of that 20% and make the behavior match the
> documentation. Question for the list: is this a bad change? Is anyone
> out there actually using this undocumented behavior?
Yes, please fix it. In fact, I think we should throw an error if more
than one character is specified as a delimiter. Saying we ignore
multiple characters in the documentation is not enough when we silently
ignore them in the code.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bill Studenmund | 2001-12-04 20:12:19 | Re: Undocumented feature costs a lot of performance in |
| Previous Message | Bruce Momjian | 2001-12-04 19:55:30 | Re: Problem (bug?) with like |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bill Studenmund | 2001-12-04 20:12:19 | Re: Undocumented feature costs a lot of performance in |
| Previous Message | Tom Lane | 2001-12-04 19:49:05 | Undocumented feature costs a lot of performance in COPY IN |