Skip site navigation (1) Skip section navigation (2)

Re: [PATCHES] Re: [PATCH] Cleanup of JDBC character encoding

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Anders Bengtsson <ndrsbngtssn(at)yahoo(dot)se>
Cc: Barry Lind <barry(at)xythos(dot)com>, pgsql-jdbc(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCHES] Re: [PATCH] Cleanup of JDBC character encoding
Date: 2001-07-12 20:12:44
Message-ID: 200107122012.f6CKCiJ28212@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-jdbcpgsql-patches
Here is the right one:

Your patch has been added to the PostgreSQL unapplied patches list at:

	http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

> On Mon, 9 Jul 2001, Barry Lind wrote:
> 
> > Anders,
> >
> > I have some issues with this patch.
> >
> > 1) Please don't require the driver to perform yet another round trip to
> > the server to get the database encoding.  You changed the following code
> > which accessed the server once at connection creation:
> [snip]
> > 2) I don't like having test specific code in Encoding.java, specifically
> > the dummy encoding 'X-UNIT-TESTS'.
> 
> Thanks Barry, I'll fix these things and return with a new patch.
> 
> I think I'll be able to get pretty good test coverage even without the
> extra test data.
> 
> /Anders
> _____________________________________________________________________
> A n d e r s  B e n g t s s o n                   ndrsbngtssn(at)yahoo(dot)se
> Stockholm, Sweden
> 
> 
> _________________________________________________________
> Do You Yahoo!?
> Get your free @yahoo.com address at http://mail.yahoo.com
> 
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
>     (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
> 

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

In response to

pgsql-patches by date

Next:From: Bruce MomjianDate: 2001-07-12 20:34:59
Subject: Re: Re: [PATCHES] Re: [PATCH] Cleanup of JDBC character encoding
Previous:From: Bruce MomjianDate: 2001-07-12 20:09:39
Subject: Re: [PATCH] Cleanup of JDBC character encoding

pgsql-jdbc by date

Next:From: Bruce MomjianDate: 2001-07-12 20:34:59
Subject: Re: Re: [PATCHES] Re: [PATCH] Cleanup of JDBC character encoding
Previous:From: Martín MarquésDate: 2001-07-12 20:12:04
Subject: Re: vacuum and 24/7 uptime

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group