Re: pgsql/ ontrib/pg_dumplo/lo_export.c ontrib/pg_ ...

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: The Hermit Hacker <scrappy(at)hub(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql/ ontrib/pg_dumplo/lo_export.c ontrib/pg_ ...
Date: 2001-03-22 18:29:03
Message-ID: 200103221829.NAA08009@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Yea, kind of bad, huh? That is the only way to prevent the comment
> > wrapping, unless we add /* --- to those comments.
>
> What I'm complaining about is that that comment HAD the dashes, and
> you gratuitously removed them. You promised me some time ago that
> pgindent wouldn't mess up dash-protected comments. You're violating
> the terms of that armistice ...

Yes, I did.

I assumed /* ---- comments were used to protect pre-indented comment
text, an item Thomas has mentioned, and something I did properly
preserve. I did not know it was being used for x = y wrap protection.

I just did:

$ rgrepc ' [/ ]\* .*=$'

and

$ rgrepc ' [/ ]\* ='

and see the comment you mentioned. Let me go through and look at all
the equals wraps and re-add the dashes for you.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2001-03-23 00:36:38 pgsql/src/bin/psql mainloop.c startup.c
Previous Message Tom Lane 2001-03-22 18:13:16 Re: pgsql/ ontrib/pg_dumplo/lo_export.c ontrib/pg_ ...