Re: pgindent run?

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: The Hermit Hacker <scrappy(at)hub(dot)org>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgindent run?
Date: 2001-03-22 01:24:19
Message-ID: 200103220124.UAA02867@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

> On Wed, 21 Mar 2001, Bruce Momjian wrote:
>
> >
> > OK, I am going to have dinner and then get started on the pgindent run.
> >
> > I have also noticed we have some comments like:
> >
> > /* ----
> > * one word
> > * ----
> > */
> >
> > that look funny in a few places. I propose:
> >
> > /* one word */
> >
> > to be consistent.
>
> to be consistent with what ... ? isn't:
>
> /* ----------
> * comment
> * ----------
> */
>
> the standard?

Sorry. It has been a while since I studied this. The issue is the
dashes, not the block comments. /* --- is needed for multi-line comment
where you want to preserve the layout, but in other cases, it prevents
comment layout and looks kind of heavy. I eyeball each change to make
sure it is clean so:

/* ---
* test
* ---
*/

becomes the cleaner:

/*
* test
*/

This makes the comment easier to read.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Philip Warner 2001-03-22 01:30:19 Re: More on elog and error codes
Previous Message Steven Vajdic 2001-03-22 01:03:16 Migration - Linux/pgSQL/PHP (type,version)

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2001-03-22 03:58:49 Re: pgindent run?
Previous Message The Hermit Hacker 2001-03-21 23:25:49 Re: pgindent run?