Re: beta6 pg_restore core dumps

From: Martin Renters <martin(at)datafax(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>, Martin Renters <martin(at)datafax(dot)com>, Philip Warner <pjw(at)rhyme(dot)com(dot)au>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: beta6 pg_restore core dumps
Date: 2001-03-19 15:40:56
Message-ID: 20010319104056.A7239@snowbird.datafax.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Mar 17, 2001 at 12:31:20PM -0500, Tom Lane wrote:
> After looking more closely I see that pg_restore has two different
> buffer overrun conditions in this one routine. Attached is take two
> of my patch.
>
> This would be a lot simpler and cleaner if _PrintData() simply didn't
> append a zero byte to the buffer contents. Philip, is it actually
> necessary for it to do that?

This patch seems to fix the problem I was seeing.

Martin

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2001-03-19 16:09:45 Re: Performance monitor signal handler
Previous Message Bruce Momjian 2001-03-19 14:59:03 Re: Re: Small bug in pg_dump