Re: (one more time) Patches with vacuum fixes available .

* Andrew Snow <als(at)fl(dot)net(dot)au> [001211 20:21] wrote:
>
> On Mon, 11 Dec 2000, Tom Lane wrote:
>
> > "Mikheev, Vadim" <vmikheev(at)SECTORBASE(dot)COM> writes:
> > > If there are no objections then I'm ready to add changes to 7.1.
> > > Else, I'll produce patches for 7.1 just after release and incorporate
> > > changes into 7.2.
> >
> > I'd vote for the second choice. I do not think we should be adding new
> > features now. Also, I don't know about you, but I have enough bug fix,
> > testing, and documentation work to keep me busy till January even
> > without any new features...
>
> It'd be really naughty to add it to the beta at this stage. Would it be
> possible to add it to the 7.1 package with some kind of compile-time option?
> So that those of us who do want to use it, can.

One is a compile time option (CFLAGS+=-DMMNB), the other doesn't
happen unless you ask for it:

vacuum lazy <table>;

I don't understand what the deal here is, as I said, it's optional
code that you won't see unless you ask for it.

[children: 0 12/11/2000 21:57:20 xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
Vacuuming link.
[children: 0 12/11/2000 21:57:54 xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]

-rw------- 1 pgsql pgsql 134627328 Dec 11 21:57 link
-rw------- 1 pgsql pgsql 261201920 Dec 11 21:57 link_triple_idx

Yup, 30 seconds, the table is 134 megabytes and the index is 261 megs.

I think normally this takes about 10 or so _minutes_.

On our faster server:

[children: 0 12/11/2000 22:17:50 xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]
Vacuuming referer_link.
[children: 0 12/11/2000 22:18:09 xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx]

-rw------- 1 pgsql wheel 273670144 Dec 11 22:15 link
-rw------- 1 pgsql wheel 641048576 Dec 11 22:15 link_triple_idx

time is ~19seconds, table is 273 megs, and index 641 megs.

dual 800mhz, raid 5 disks.

I think the users deserve this patch. :)

--
-Alfred Perlstein - [bright(at)wintelcom(dot)net|alfred(at)freebsd(dot)org]
"I have the heart of a child; I keep it in a jar on my desk."