Re: Questionable coding in proc.c & lock.c

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Thomas Lockhart <lockhart(at)alumni(dot)caltech(dot)edu>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Hiroshi Inoue <Inoue(at)tpf(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Questionable coding in proc.c & lock.c
Date: 2000-07-28 15:51:57
Message-ID: 200007281551.LAA28326@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> > I think maybe what needs to be done to fix all this is to restructure
> > postgres.c's interface to the parser/rewriter. What we want is to
> > run just the yacc grammar initially to produce a list of raw parse
> > trees (which is enough to detect begin/commit/rollback, no?) Then
> > postgres.c walks down that list, and for each element, if it is
> > commit/rollback OR we are not in abort state, do parse analysis,
> > rewrite, planning, and execution. (Thomas, any comments here?)
>
> Sure, why not (restructure postgres.c that is)? I was just thinking
> about how to implement "autocommit" and was considering doing a hack in
> analyze.c which just plops a "BEGIN" in front of the existing query. But

Man, that is something I would do. :-)

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2000-07-28 15:59:42 Re: Questionable coding in proc.c & lock.c
Previous Message Bruce Momjian 2000-07-28 15:42:41 Re: Re: Another TODO: insert/update...returning