Re: config.h (was Re: Misc. consequences of backend memory management changes)

From: Brook Milligan <brook(at)biology(dot)nmsu(dot)edu>
To: tgl(at)sss(dot)pgh(dot)pa(dot)us
Cc: peter_e(at)gmx(dot)net, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: config.h (was Re: Misc. consequences of backend memory management changes)
Date: 2000-06-30 14:56:26
Message-ID: 200006301456.IAA05428@biology.nmsu.edu
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

One thing that does occur to me is that a very large fraction of
config.h is now symbols that are supposed to be set by configure,
and as you say it's not good to give people the idea that they
should tweak those results by hand after configuring. What do you
think of pulling the remaining hand-settable symbols out into a
separate file, maybe called something like "siteconfig.h"? Then
config.h becomes purely a machine-generated file. This would
also solve the problem of losing hand-set config choices if you
rerun configure.

config.h should contain only machine generated stuff for exactly the
reasons you mention. Perhaps config.h.in should be something like:

/* siteconfig.h overrides various variables */
#include "siteconfig.h"

/* enable feature FOO (can be overridden by siteconfig.h) */
#ifndef FOO
#undefine FOO
#endif

Cheers,
Brook

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Brook Milligan 2000-06-30 15:17:27 Re: Changes to handling version numbers internally
Previous Message Fabrizio Sciarra 2000-06-30 14:40:56 PostgreSQL + Solaris + Mico + Purify = ????