Re: freefuncs.c is never called from anywhere!?]

> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> >> It's tough to maintain clear module APIs with tools like
> >> that second-guessing the author's intentions.
>
> > Also, I don't touch the interfaces, only the backend code. There aren't
> > many api stuff there, except spi, which I also don't touch.
>
> I was talking about intermodule APIs within the backend...

Can you give an example? You mean a function that is meant to be
exported to other modules in the backend, but is not called for some
reason should not be marked as static?

Yes, that is an issue, but reducing our code size and marking functions
static/NOT_USED seems to be a larger benfit. Of course, IMHO.

--
Bruce Momjian | http://www.op.net/~candle
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026