Re: New warning code for missing FROM relations

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: New warning code for missing FROM relations
Date: 2000-06-03 14:00:46
Message-ID: 200006031400.KAA19022@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > I have committed new warning code to alert users who auto-create
> > relations without knowing it.
> > The code issues the warning if it auto-creates a range table entry, and
> > there is already a range table entry identified as coming from a FROM
> > clause. Correlated subqueries should not be a problem because they are
> > not auto-created.
>
> I still prefer the suggestion I made before: complain only if the
> implicit FROM entry is for a table already present in the rangelist
> (under a different alias, obviously). The fact that that choice
> would not break any existing regression tests seems relevant...

But it seems mine is going to complain if they forget one in a FROM
clause, which sort of makes sense to me. I can do your suggestion, but
this makes more sense. Can we get some other votes?

--
Bruce Momjian | http://www.op.net/~candle
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Louis-David Mitterrand 2000-06-03 15:22:56 child table doesn't inherit PRIMARY KEY?
Previous Message Giles Lean 2000-06-03 12:59:34 Re: Industrial-Strength Logging