From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp> |
Cc: | pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: ecpg enhance patch |
Date: | 2000-06-01 22:03:17 |
Message-ID: | 200006012203.SAA02738@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Can I get a comment on this? It has not been applied. It appears to
apply to an older release. New new file name is
interfaces/ecpg/lib/execute.c.
> Here is a patch that would enhance the efficiency in that skip strings
> which have been already checked. The patch was made by Kazuko
> Nakagawa. Michael, can you comment on this?
>
> *** ecpglib.c.orig Wed Dec 22 13:13:21 1999
> --- ecpglib.c Wed Dec 22 13:37:32 1999
> ***************
> *** 398,403 ****
> --- 398,404 ----
> PGresult *results;
> PGnotify *notify;
> struct variable *var;
> + int hostvarl = 0;
>
> copiedquery = ecpg_strdup(stmt->command, stmt->lineno);
>
> ***************
> *** 569,575 ****
> return false;
>
> strcpy(newcopy, copiedquery);
> ! if ((p = next_insert(newcopy)) == NULL)
> {
>
> /*
> --- 570,576 ----
> return false;
>
> strcpy(newcopy, copiedquery);
> ! if ((p = next_insert(newcopy+hostvarl)) == NULL)
> {
>
> /*
> ***************
> *** 582,587 ****
> --- 583,589 ----
> else
> {
> strcpy(p, tobeinserted);
> + hostvarl = strlen(newcopy);
>
> /*
> * The strange thing in the second argument is the rest of the
>
>
> ************
>
--
Bruce Momjian | http://www.op.net/~candle
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2000-06-01 22:22:10 | Re: INET operators and NOT |
Previous Message | Tom Lane | 2000-06-01 21:48:23 | Re: Problems with recent CVS versions and Solaris. |