Re: WIP patch - INSERT-able log statements

From: "Guillaume Smet" <guillaume(dot)smet(at)gmail(dot)com>
To: "Greg Smith" <gsmith(at)gregsmith(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: WIP patch - INSERT-able log statements
Date: 2007-02-18 11:07:49
Message-ID: 1d4e0c10702180307s7957f53v8ef28b36ce8bac38@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Added -hackers to CC:.

On 2/18/07, Greg Smith <gsmith(at)gregsmith(dot)com> wrote:
> I've thought a bit about how to implement this TODO already (I have a log
> file parser and I hate maintaining it)

Any problem using pgFouine?

> Also, I feel that supporting the whole log_line_prefix syntax for this
> feature is not just overkill, it's a bad idea. Output everything in a
> standard, complete format instead, and then it becomes easy for the
> community at large to build tools on top of that to analyze the log
> database entries instead of having so many ad-hoc approaches. You want a
> subset, use a view or copy just the fields you want into another table.
> I would guess this simplifies the patch as well.

I agree with you on this point. We need every information we can put
in the database (database, user and so on) in a structured way.

Logging statements is not the only thing to do IMHO. Logging errors in
another table is important too. I'm pretty sure there are a lot people
who don't know if there are errors in their statements.

Anyway, if something is developed to do that, I'll extend pgFouine to
support it (or I'll write another application to do it) and I'm pretty
sure others will do. The most annoying and difficult part of the work
on pgFouine/PQA/... is to maintain the parser. If we don't have to do
that anymore, we'll have more time to think about new features.
In fact, it was a long plan for pgFouine to be able to store the
results of its analysis in a database so it's a good news if it's
implemented in core.

--
Guillaume

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Russell Smith 2007-02-18 12:36:12 Re: Plan invalidation design
Previous Message Karsten Hilbert 2007-02-18 10:38:15 Re: [ANNOUNCE] Advisory on possibly insecure security definer functions

Browse pgsql-patches by date

  From Date Subject
Next Message Heikki Linnakangas 2007-02-18 16:29:12 Re: further bootstrap cleanup
Previous Message Greg Smith 2007-02-18 07:25:40 Re: WIP patch - INSERT-able log statements