Re: [PATCHES] Patch to log usage of temporary files

From: "Guillaume Smet" <guillaume(dot)smet(at)gmail(dot)com>
To: "Bruce Momjian" <bruce(at)momjian(dot)us>
Cc: "Bill Moran" <wmoran(at)collaborativefusion(dot)com>, pgsql-patches(at)postgresql(dot)org, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCHES] Patch to log usage of temporary files
Date: 2007-01-12 19:23:21
Message-ID: 1d4e0c10701121123v7dbac21fqe298046b05c35896@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Hi Bruce,

Thanks for your answer.

On 1/12/07, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> We have the ability to conditionally print statements based on error
> level, but LOG isn't a valid level for log_min_error_statement.
>
> We could add a parameter that few people would use, but the right way to
> do this is to log all queries.
>
> We do not allow unlimited logging control or the system would be too
> complex.

That's not what I had in mind. I was asking if the text of the query
was available when logging the temp file usage. If so it could be good
to add a DETAIL line with it directly and systematically when logging
the temp file usage.

Sure that if you log every query, you could find which query was
responsible for that temp file but I suspect that this new log
feature will be used on production servers and so usually without
statement logging enabled.

IMHO, it's really important to know which queries are responsible for
the temp file usage.

If the text of the query is not available when logging the temp file
usage then I agree that we cannot do anything.

--
Guillaume

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2007-01-12 19:29:05 Re: [HACKERS] [PATCHES] Patch to log usage of temporary files
Previous Message Bruce Momjian 2007-01-12 19:12:48 Re: [PATCHES] Patch to log usage of temporary

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-01-12 19:29:05 Re: [HACKERS] [PATCHES] Patch to log usage of temporary files
Previous Message Bruce Momjian 2007-01-12 19:12:48 Re: [PATCHES] Patch to log usage of temporary