Re: Inconsistency in extended-query-protocol logging

From: "Guillaume Smet" <guillaume(dot)smet(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Inconsistency in extended-query-protocol logging
Date: 2006-09-13 16:06:16
Message-ID: 1d4e0c10609130906w5ae56e94i5acb016d56a915ac@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 9/13/06, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> statement: querystring Simple Query
> parse <stmt>: querystring Parse
> bind <stmt>/<portal>: querystring Bind
> execute <stmt>/<portal>: querystring Execute

I agree with that.
Hmmm, AFAICS, you changed "<stmt>/<portal>" to "<portal> to
<statement>" in your last commit. Or did I misunderstand?

> or these prefixed with "duration: xxx", as appropriate. Bruce was
> pretty hot about having statement: in there, so the hard part might
> be to convince him.

Bruce, any opinion? I really think the extended query protocol is not
a statement stricly speaking.

> Also, the current code distinguishes a "fetch" from an
> already-partially-executed portal ... do you care about that?

I don't really understand what is a portal - I must admit I don't use
libpq directly. I never saw a log file with fetch. Do you have an
example? Should I consider an execute from fetch differently?

--
Guillaume

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-09-13 16:28:47 Re: contrib uninstall scripts need some love
Previous Message Tom Lane 2006-09-13 15:52:05 Re: Inconsistency in extended-query-protocol logging