Re: [HACKERS] Problems with src/pl/tcl/mkMakefile.tcldefs.sh.in in 6.5

On Sat, Jul 10, 1999 at 02:45:47AM -0400, Bruce Momjian wrote:
> I didn't understand this the first time you sent it either.
>
> Send me a patch to review, please.

--- src/pl/tcl/mkMakefile.tcldefs.sh.in.orig Fri Jul 9 08:29:09 1999
+++ src/pl/tcl/mkMakefile.tcldefs.sh.in Fri Jul 9 08:29:49 1999
@@ -8,9 +8,6 @@

cat @TCL_CONFIG_SH@ |
egrep '^TCL_|^TK_' |
- while read inp
- do
- eval eval echo $inp
- done >Makefile.tcldefs
+ sed -e "s/^\([^=]*\)='\(.*\)'$/\1=\2/" >Makefile.tcldefs

exit 0

>
> > For Digital UNIX 4.0D, shared libraries are created by:
> > $ ld -shared -expect_unresolved "*" -o foo.so [objects]
> >
> > This presents a problem for mkMakefile.tcldefs.sh.in. In tclConfig.sh:
> > TCL_SHLIB_LD='ld -shared -expect_unresolved "*"'
> >
> > In mkMakefile.tcldefs.sh.in:
> > cat @TCL_CONFIG_SH@ |
> > egrep '^TCL_|^TK_' |
> > while read inp
> > do
> > eval eval echo $inp
> > done >Makefile.tcldefs
> >
> > Because of this, we wind up with the following in Makefile.tcldefs to
> > created shared libraries on Digital UNIX because of the eval:
> > TCL_SHLIB_LD=ld -shared -expect_unresolved *
> >
> > The "*" needs to be quoted to avoid shell expansion. How about the
> > following:
> > cat @TCL_CONFIG_SH@ |
> > egrep '^TCL_|^TK_' |
> > sed -e "s/^\([^=]*\)='\(.*\)'$/\1=\2/"
> >
> > --
> > albert chin (china(at)thewrittenword(dot)com)
>
> --
> Bruce Momjian | http://www.op.net/~candle

--
albert chin (china(at)thewrittenword(dot)com)