Re: [HACKERS] large objects failing (hpux10.20 sparc/solaris 2.6, gcc 2.8.1)

Applied to the main tree. I found the patch malformed, so I applied it
by hand. Interesting you had to double-align.

> >> I applied the patches to my 6.4.2 source tree (not the snapshot)--
> >> the patches applied cleanly, but my backend still goes into never never
> >> land at the line I mentioned before. What version of gcc are you using?
> >> Would it be useful for me to post any additional info?
> >
> >Let me try on Solaris2.6/sparc in my office first. Today is Saturday
> >in Japan, so the testing will be the day after tomorrow. Is it ok for
> >you?
>
> Ok. I found an align problem in lobj that might not appear other than
> Solaris/sparc. Please apply included patches to
> src/backend/storage/large_object/inv_api.c and try again. (These are
> addtions to the previous ones).
>
> Hope this is the last bug:-)
> --
> Tatsuo Ishii
> --------------------------------------------------------------------
> *** inv_api.c.orig2 Mon Feb 22 16:15:31 1999
> --- inv_api.c Mon Feb 22 16:16:55 1999
> ***************
> *** 1019,1028 ****
>
> /* compute tuple size -- no nulls */
> hoff = offsetof(HeapTupleData, t_bits);
>
> /* add in olastbyte, varlena.vl_len, varlena.vl_dat */
> tupsize = hoff + (2 * sizeof(int32)) + nwrite;
> ! tupsize = LONGALIGN(tupsize);
>
> /*
> * Allocate the tuple on the page, violating the page abstraction.
> --- 1019,1029 ----
>
> /* compute tuple size -- no nulls */
> hoff = offsetof(HeapTupleData, t_bits);
> + hoff = DOUBLEALIGN(hoff);
>
> /* add in olastbyte, varlena.vl_len, varlena.vl_dat */
> tupsize = hoff + (2 * sizeof(int32)) + nwrite;
> ! tupsize = DOUBLEALIGN(tupsize);
>
> /*
> * Allocate the tuple on the page, violating the page abstraction.
>
>

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026