Re: [HACKERS] large objects failing (hpux10.20 sparc/solaris 2.6, gcc 2.8.1)

From: Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>
To: t-ishii(at)sra(dot)co(dot)jp
Cc: Ron Snyder <snyder(at)athena(dot)lblesd(dot)k12(dot)or(dot)us>, hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] large objects failing (hpux10.20 sparc/solaris 2.6, gcc 2.8.1)
Date: 1999-02-22 07:30:12
Message-ID: 199902220730.QAA11332@srapc451.sra.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>> I applied the patches to my 6.4.2 source tree (not the snapshot)--
>> the patches applied cleanly, but my backend still goes into never never
>> land at the line I mentioned before. What version of gcc are you using?
>> Would it be useful for me to post any additional info?
>
>Let me try on Solaris2.6/sparc in my office first. Today is Saturday
>in Japan, so the testing will be the day after tomorrow. Is it ok for
>you?

Ok. I found an align problem in lobj that might not appear other than
Solaris/sparc. Please apply included patches to
src/backend/storage/large_object/inv_api.c and try again. (These are
addtions to the previous ones).

Hope this is the last bug:-)
--
Tatsuo Ishii
--------------------------------------------------------------------
*** inv_api.c.orig2 Mon Feb 22 16:15:31 1999
--- inv_api.c Mon Feb 22 16:16:55 1999
***************
*** 1019,1028 ****

/* compute tuple size -- no nulls */
hoff = offsetof(HeapTupleData, t_bits);

/* add in olastbyte, varlena.vl_len, varlena.vl_dat */
tupsize = hoff + (2 * sizeof(int32)) + nwrite;
! tupsize = LONGALIGN(tupsize);

/*
* Allocate the tuple on the page, violating the page abstraction.
--- 1019,1029 ----

/* compute tuple size -- no nulls */
hoff = offsetof(HeapTupleData, t_bits);
+ hoff = DOUBLEALIGN(hoff);

/* add in olastbyte, varlena.vl_len, varlena.vl_dat */
tupsize = hoff + (2 * sizeof(int32)) + nwrite;
! tupsize = DOUBLEALIGN(tupsize);

/*
* Allocate the tuple on the page, violating the page abstraction.

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Mohamed Hefny 1999-02-22 09:26:37 Playing with postgres
Previous Message Thomas G. Lockhart 1999-02-22 07:05:54 Re: [HACKERS] optimizer cleanup