Re: [HACKERS] Please check...ignore them...

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: scrappy(at)hub(dot)org (The Hermit Hacker)
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] Please check...ignore them...
Date: 1998-12-14 04:03:39
Message-ID: 199812140403.XAA06781@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>
> Everything is in CVS, if I oops, its recoverable...am removing all code
> that has either:
>
> #if 0
>
> or
>
> #ifdef FALSE
>
> surrounding it, since it isn't used...we have the logs and diffs in the
> CVS repository if I make a mistake, but since it isn't used, can't see how
> I can make a mistake :)

Yep, except there is some code if'defed out that could be useful some
day. The one from dbcommand.c clearly would never be useful.
Basically, if you can figure out what the ifdef 0 did, and you see a
replacement in the code, you can remove it. That is the guide I use.

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message The Hermit Hacker 1998-12-14 04:06:11 Alot of code...NOT_USED...
Previous Message The Hermit Hacker 1998-12-14 04:03:36 Reason for commands/user.c?