Re: [HACKERS] Bug in gram.y?

From: t-ishii(at)sra(dot)co(dot)jp
To: "Thomas G(dot) Lockhart" <lockhart(at)alumni(dot)caltech(dot)edu>
Cc: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>, "Dr(dot) Michael Meskes" <meskes(at)online-club(dot)de>, pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] Bug in gram.y?
Date: 1998-08-04 02:31:40
Message-ID: 199808040231.LAA25087@srapc451.sra.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>> > it seems that it doesn't accept a createdb with the
>> > option location = ... but without the option encoding = ...
>
>I think the code is sub-optimal for a couple of reasons:
>
>1) LOCATION must be the first argument, ENCODING must be the second. The
>number and order of any options should be flexible.
>
>2) the options should have a comma delimiter between them. Currently
>they do not. To introduce the comma delimiter will require restructuring
>that part of the parsing, but isn't a big deal.
>
>I'm pretty sure that the options can be specified individually, but it
>does not generalize well. The two specific problems above should be
>considered fatal for a final version :/
>
>I've worked through problems like this for other SQL92 syntax, and can
>probably fix up this one too. Will put it on my list unless someone else
>wants it...

I'm responsible for that problem. But seems you have a better
solution. Please take it.
--
Tatsuo Ishii
t-ishii(at)sra(dot)co(dot)jp

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 1998-08-04 03:45:33 Re: [PG95-DEV] Rule system
Previous Message Thomas G. Lockhart 1998-08-04 02:10:02 Re: [HACKERS] Bug in gram.y?