| From: | Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us> | 
|---|---|
| To: | vadim(at)sable(dot)krasnoyarsk(dot)su (Vadim B(dot) Mikheev) | 
| Cc: | ssimkovi(at)ag(dot)or(dot)at, stefan(at)stefan(dot)co(dot)at, hackers(at)postgreSQL(dot)org | 
| Subject: | Re: [HACKERS] Re: Having Patch (against v6.3.2) | 
| Date: | 1998-07-19 10:06:26 | 
| Message-ID: | 199807191006.GAA25664@candle.pha.pa.us | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-hackers | 
> > 3) Bug in ExecMergeJoin ??
> >    This is something that has *NOTHING* to do with the Having logic!
> >    Proof: Try the following query (without having my patch applied):
> > 
> >                      ....
> >                      CleanUpSort(node->join.lefttree->lefttree);
> >                      CleanUpSort(node->join.righttree->lefttree);
> > 	          ....
> >                 }		
> >                  
> >     In 'CleanUpSort()' the function 'psort_end()' gets called and
> >     closes down the sort, which is correct as long as no subselects 
> >     are in use!
I looked at the Mariposa code, which has some fixes, and they have
removed the call to CleanUpSort in mergejoin, so that verifies the fix
is correct.  I am removing the entire CleanUpSort function and calls from
mergejoin.
-- 
Bruce Momjian                          |  830 Blythe Avenue
maillist(at)candle(dot)pha(dot)pa(dot)us              |  Drexel Hill, Pennsylvania 19026
  +  If your life is a hard drive,     |  (610) 353-9879(w)
  +  Christ can be your backup.        |  (610) 853-3000(h)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 1998-07-19 10:19:59 | Removal of recipe/tioga/Tee node | 
| Previous Message | Bruce Momjian | 1998-07-19 09:59:30 | Re: [HACKERS] Re: Having Patch (against v6.3.2) |