new lock structure names

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: hackers(at)postgreSQL(dot)org (PostgreSQL-development)
Subject: new lock structure names
Date: 1998-06-30 02:09:29
Message-ID: 199806300210.WAA03836@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I have renamed most of the variables/structures in
backend/storage/lmgr/lock.c. The old names were very confusing.

Names like LOCKTAB, LOCKCTL, ltable, ntypes, AllTables, locktype,
LockTableInit, tableId, tableID, lockName are gone. There are two
primary items in lock.c. One is the locking method. Currently we only
support multi-level locks. The second is lock mode (read/write). These
were very unclear in the code. Now, I can understand what is happening,
and I hope others can too.

I have attatched the contents of the README in that directory, to show
that someone in 1992 also agrees with me, in case some want to complain
that I changed some variable names.

---------------------------------------------------------------------------

This file is an attempt to save me (and future code maintainers) some
time and a lot of headaches. The existing lock manager code at the time
of this writing (June 16 1992) can best be described as confusing. The
complexity seems inherent in lock manager functionality, but variable
names chosen in the current implementation really confuse me everytime
I have to track down a bug. Also, what gets done where and by whom isn't
always clear....

--
Bruce Momjian | 830 Blythe Avenue
maillist(at)candle(dot)pha(dot)pa(dot)us | Drexel Hill, Pennsylvania 19026
+ If your life is a hard drive, | (610) 353-9879(w)
+ Christ can be your backup. | (610) 853-3000(h)

Browse pgsql-hackers by date

  From Date Subject
Next Message Vadim Mikheev 1998-06-30 04:20:02 Re: [HACKERS] now 6.4
Previous Message The Hermit Hacker 1998-06-30 02:01:20 Re: [HACKERS] now 6.4