From: | Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | tgl(at)sss(dot)pgh(dot)pa(dot)us (Tom Lane) |
Cc: | hackers(at)postgreSQL(dot)org |
Subject: | Re: [HACKERS] removal of braces |
Date: | 1998-06-16 07:23:51 |
Message-ID: | 199806160723.DAA07986@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
>
> Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us> writes:
> > I am sure there were some bugs fixed by this cleanup.
>
> And some introduced, most likely. Just how much does your script know
> about C syntax, macros, etc?
I have posted the patch to the list.
>
> I concur with David Gould that this is a risky, expensive exercise
> with very little potential gain.
>
> If you were able to identify any spots with the sort of macro-induced
> bug you illustrated, great! Fix 'em by hand. But I doubt that a
> 12000-line wholesale modification is worth the trouble. Heck, half
> the code I've looked at in pgsql doesn't even conform to indentation/
> tab-width conventions ... and *those* we have well-tested tools to fix.
That is more work than fixing all the macros. I think 98% should be
properly formatted for 4-space tabs. I run pgindent just before every
beta period, and have added the brace removal code to pgindent.
I got tired of removing them as I saw them. Now, we have a standard.
--
Bruce Momjian | 830 Blythe Avenue
maillist(at)candle(dot)pha(dot)pa(dot)us | Drexel Hill, Pennsylvania 19026
+ If your life is a hard drive, | (610) 353-9879(w)
+ Christ can be your backup. | (610) 853-3000(h)
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 1998-06-16 07:53:39 | Re: [HACKERS] Current sources? |
Previous Message | Bruce Momjian | 1998-06-16 07:22:07 | Re: [HACKERS] removal of braces |