From: | Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | t-ishii(at)sra(dot)co(dot)jp (Tatsuo Ishii) |
Cc: | lockhart(at)alumni(dot)caltech(dot)edu, ports(at)postgreSQL(dot)org, hackers(at)postgreSQL(dot)org, t-ishii(at)sra(dot)co(dot)jp |
Subject: | Re: [HACKERS] Platform status |
Date: | 1998-02-21 05:18:04 |
Message-ID: | 199802210518.AAA16135@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
I will fix this. Thanks for the report. Must have been tough to find.
>
> At 4:06 PM 98.2.19 +0000, Thomas G. Lockhart wrote:
> >Here is my current list of supported platforms. The outstanding issues
> >are:
>
> >mklinux/ppc - still core dumping on regression tests? why??
>
> I finally found the source of the problem. function "_readConst" in
> backend/nodes/readfuncs.c there is a line:
>
> local_node->constlen = strtoul(token,NULL,10);
>
> (before 6.3beta, this was:
> local_node->constlen = atol(token);
> )
>
> For text type constant, token would be "-1." In this case
> strtoul() of mklinux/ppc returns 0 not ULONG_MAX (same bit
> pattern as -1). This is a problem.
> So quick workaround might be surrounding the line by #ifdef like:
>
> #ifdef PPC
> local_node->constlen = atol(token);
> #else
> local_node->constlen = strtoul(token,NULL,10);
> #endif
>
> P.S.
> Sure current code works except MkLinux/ppc. However calling with
> strtoul() with minus value is not well-mannered IMHO
> (strtoul() returns error code ERANGE in this case).
> To make matters worse, there are some codes that comparing
> constlen and -1.
> What about changing constlen to signed int and using
> strtol() instead of strtoul() here?
> Tatsuo Ishii
> t-ishii(at)sra(dot)co(dot)jp
>
>
>
--
Bruce Momjian
maillist(at)candle(dot)pha(dot)pa(dot)us
From | Date | Subject | |
---|---|---|---|
Next Message | Julia A.Case | 1998-02-21 06:35:49 | Sparc/Linux oddity... |
Previous Message | Tatsuo Ishii | 1998-02-21 04:38:02 | Re: [HACKERS] Platform status |