Re: [HACKERS] CREATE FUNCTION broken

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: jwieck(at)debis(dot)com
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] CREATE FUNCTION broken
Date: 1998-02-13 18:28:07
Message-ID: 199802131828.NAA14798@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I added typmod to the TypeName structure, but am not aware of adding any
TypeName structure instance to anything.

Nice you have a patch for us.

>
> Hi,
>
> Someone changed the parser to build a TypeName node on CREATE
> FUNCTION in any case. As a side effect, ALL! functions
> created got the proretset attribute to true. Thus for a
> SELECT the parser wrapped an Iter node around the Expr and
> since singleton functions set isDone the Iter returns no
> tuple up.
>
>
> Until later, Jan
>
> --
>
> #======================================================================#
> # It's easier to get forgiveness for being wrong than for being right. #
> # Let's break this rule - forgive me. #
> #======================================== jwieck(at)debis(dot)com (Jan Wieck) #
>
>
> *** define.c.orig Fri Feb 13 12:14:17 1998
> --- define.c Fri Feb 13 12:14:38 1998
> ***************
> *** 94,100 ****
> TypeName *setType = (TypeName *) returnType;
>
> *prorettype_p = setType->name;
> ! *returnsSet_p = true;
> }
> else
> {
> --- 94,100 ----
> TypeName *setType = (TypeName *) returnType;
>
> *prorettype_p = setType->name;
> ! *returnsSet_p = setType->setof;
> }
> else
> {
>
>

--
Bruce Momjian
maillist(at)candle(dot)pha(dot)pa(dot)us

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 1998-02-13 19:27:37 Re: v6.3 release ToDo list and supported ports
Previous Message Bruce Momjian 1998-02-13 18:25:15 Re: [HACKERS] v6.3 snapshot core dump