Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p
Date: 2004-05-19 19:11:33
Message-ID: 19525.1084993893@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-patches
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> OK, I moved the find_my_exec calls to the locations you mentioned in
> both postgres.c and postmaster.c and remove it from main.c.  I tested
> the elog and it worked.

You omitted get_pkglib_path() from the postmaster case; was that
intentional?

Also, in the non-exec case it seems unnecessary and possibly unsafe to
repeat this computation in a backend.  It should inherit the settings
from the postmaster via fork(), I'd think.  So possibly

#ifndef EXEC_BACKEND
	if (!IsUnderPostmaster)
#endif
	{
		find_my_exec(...);
		get_pkglib_path(...);
	}


			regards, tom lane

In response to

Responses

pgsql-committers by date

Next:From: Bruce MomjianDate: 2004-05-19 19:39:05
Subject: Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p
Previous:From: Bruce MomjianDate: 2004-05-19 19:11:26
Subject: pgsql-server/src/backend/postmaster postmaster.c

pgsql-patches by date

Next:From: Bruce MomjianDate: 2004-05-19 19:39:05
Subject: Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p
Previous:From: Bruce MomjianDate: 2004-05-19 19:02:10
Subject: Re: [COMMITTERS] pgsql-server/src backend/main/main.c backend/p

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group