Re: Variable renaming in AllocSetContextCreate (will commit soon, no functional impact)

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Variable renaming in AllocSetContextCreate (will commit soon, no functional impact)
Date: 2015-02-22 05:07:17
Message-ID: 1944.1424581637@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jeff Davis <pgsql(at)j-davis(dot)com> writes:
> This is just to make the variable names in this function consistent with
> the rest of the file (and less confusing). No functional impact, so I'll
> commit soon unless someone objects.

If I'm reading this right, this creates two different variables pointing
at the same object. That does not sound like an improvement from a
readability standpoint.

If you want to have just *one* variable but change its name and type,
I'd be ok with that.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2015-02-22 07:05:01 Re: PATCH: decreasing memory needlessly consumed by array_agg
Previous Message Petr Jelinek 2015-02-22 04:29:03 Re: Redesigning checkpoint_segments