From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Stephen Frost <sfrost(at)snowman(dot)net>, Marko Tiikkaja <marko(at)joh(dot)to>, Andres Freund <andres(at)anarazel(dot)de>, Andrew Fletcher <andy(at)prestigedigital(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
Subject: | Re: BUG #15324: Non-deterministic behaviour from parallelised sub-query |
Date: | 2018-08-20 13:29:26 |
Message-ID: | 19350.1534771766@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> On Mon, Aug 20, 2018 at 4:20 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>> On Thu, Aug 16, 2018 at 9:25 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Wed, Aug 15, 2018 at 4:40 PM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
>>> (b) Consider the presence of any window function calculation as
>>> parallel-restricted operation.
>> For this, we need to mark all the window functions like row_number,
>> rank, dense_rank, etc as parallel-restricted. Additionally, we also
>> need to detect the presence of aggregate functions that act as window
>> functions (when an OVER clause follows the call). Attached patch
>> treat_window_func_calc_parallel_restricted_v1 implements the fix.
> As this patch changes the catalog contents, we need to bump catalog
> version number. However, I have left it for later once we get a
> review and or testing of the patch.
Sounds to me like you're using the wrong approach. I would just consider
any Agg or WindowFunc node as parallel-restricted regardless of the
function it references.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Alexander Kukushkin | 2018-08-20 13:55:01 | csvlog gets crazy when csv file is not writable |
Previous Message | Stephen Frost | 2018-08-20 13:24:48 | Re: BUG #15335: Documentation is wrong about archive_command and existing files |