Re: pg_dump -Ft failed on Windows XP

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Magnus Hagander" <mha(at)sollentuna(dot)net>
Cc: "Peter Eisentraut" <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, "Yoshiyuki Asaba" <y-asaba(at)sraoss(dot)co(dot)jp>
Subject: Re: pg_dump -Ft failed on Windows XP
Date: 2006-04-20 16:07:36
Message-ID: 19296.1145549256@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
> Ok. Should be easy enough once the code is fine - can you comment on the
> patch as sent, if the code itself looks right provided i wrap it up in a
> function in port/?

Not sure if the error handling is adequate --- are there any cases
besides EEXIST that should loop?

A look at
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclib/html/_crt__tempnam.2c_._wtempnam.2c_.tmpnam.2c_._wtmpnam.asp

suggests that tempnam() is also pretty fragile, esp. if you're passing
NULLs. Apparently it won't work at all if TMP isn't set?

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Radovan Antloga 2006-04-20 16:10:21 Re: Performance decrease
Previous Message Tom Lane 2006-04-20 15:56:32 Re: Google SoC--Idea Request