Skip site navigation (1) Skip section navigation (2)

Re: BUG #3841: core dump in uuid-ossp

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Dmitriy <im(at)ionflux(dot)ru>, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #3841: core dump in uuid-ossp
Date: 2007-12-27 18:51:11
Message-ID: 19096.1198781471@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-bugs
Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
>     if (err != NULL)
>         ereport(ERROR,
>                 (errmsg("OSSP uuid failure: %s", err)));
>     else
>         ereport(ERROR,
>                 (errmsg("OSSP uuid failure: error code %d", rc)));

Maybe "OSSP uuid library failure"?  Otherwise seems OK.

> Alternatively we could pass the called function name into
> pguuid_complain, but I'm not sure it's worth the trouble (what does it
> give the user, anyway?)

Probably not much, if the uuid_error() strings are well written.

Can we throw some more specific SQLSTATE than the default "internal
error" here?  Offhand I can't think of anything, but as a rule of
thumb an ereport() ought to have an errcode().  If it really is an
internal error then elog() is good enough.

			regards, tom lane

In response to

Responses

pgsql-bugs by date

Next:From: Alvaro HerreraDate: 2007-12-27 19:40:44
Subject: Re: BUG #3841: core dump in uuid-ossp
Previous:From: Alvaro HerreraDate: 2007-12-27 17:04:37
Subject: Re: BUG #3841: core dump in uuid-ossp

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group