| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, Alex Hunsaker <badalex(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Functional dependencies and GROUP BY |
| Date: | 2010-09-05 15:35:45 |
| Message-ID: | 18819.1283700945@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> writes:
> On 5 September 2010 16:15, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I don't recall having thought about it one way or the other. What did
>> the check look like?
> Well originally it was searching indexes rather than constraints, and
> funcdeps_check_pk() included the following check:
> if (!indexStruct->indisprimary || !indexStruct->indimmediate)
> continue;
> Now its looping over pg_constraint entries, so I guess anything wtih
> con->condeferrable == true should be ignored.
Seems reasonable, will fix. Thanks for the report!
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Martijn van Oosterhout | 2010-09-05 15:51:38 | Re: Streaming a base backup from master |
| Previous Message | Dean Rasheed | 2010-09-05 15:31:16 | Re: Functional dependencies and GROUP BY |