Re: why do we have rd_istemp?

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: why do we have rd_istemp?
Date: 2010-05-31 20:12:12
Message-ID: 18590.1275336732@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Tom Lane wrote:
>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>> Given "Relation rel", it looks to me like rel->rd_rel->relistemp will
>>> always give the same answer as rel->rd_istemp. So why have both?
>>
>> Might be historical --- relistemp is pretty new.

> Is this a TODO or something we want to clean up?

Doesn't strike me that it's worth the amount of code that would have to
change. rd_istemp is known in a lot of places. Replacing it with a
double indirection doesn't seem attractive anyway.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2010-05-31 20:47:39 Re: Unexpected page allocation behavior on insert-only tables
Previous Message Tom Lane 2010-05-31 20:09:24 Re: bitmap-index-scan faster than seq-scan on full-table-scan (gin index)