Re: tsearch is non-multibyte-aware in a few places

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, pgsql-hackers(at)postgresql(dot)org, Giorgio Valoti <giorgio_v(at)mac(dot)com>
Subject: Re: tsearch is non-multibyte-aware in a few places
Date: 2008-06-19 17:23:36
Message-ID: 18302.1213896216@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> This is safe if and only if t_isspace is never true for multibyte
> characters ... can anyone think of a counterexample?

Non-breaking space is a counterexample, so I pg_mblen-ified those
loops too. Fortunately this code only executes during dictionary
cache load, so a few extra cycles aren't too critical.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Melvin Davidson 2008-06-19 22:18:14 TRIGGER or RULE for SELECT
Previous Message Tom Lane 2008-06-19 16:29:11 tsearch is non-multibyte-aware in a few places