Phil Sorber <phil(at)omniti(dot)com> writes:
> On Wed, Oct 10, 2012 at 7:54 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>> Also, do we want to centralize the definition of pg_strdup() in /port,
>> or leave each module to define it on its own?
> +1 for a centralized definition.
The difficulty with a centralized definition is that it's not clear that
the error path is or should be *exactly* the same for all these usages.
I see at least six variants right now. While some are gratuitous,
some of them are tied into local conventions of each program.
regards, tom lane