From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: Default make target in test modules |
Date: | 2016-09-08 16:52:11 |
Message-ID: | 18169.1473353531@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Tom Lane wrote:
>> I happened to notice that if you type "make" in
>> src/test/modules/test_pg_dump, you will get a "make check" action
>> not "make all".
> Strange. Don't all these makefiles depend on the pgxs stuff emitting
> something sane, which would have "all" as the first one? ... Ooh, I see
> that test_pg_dump adds "check" before including pgxs, which is what
> AFAICS causes the problem.
Right.
> I suppose this is a very easy mistake to make -- but also fortunately an
> easy one to correct. Do you want me to fix the affected modules?
I was going to do it, but if you want to, feel free.
(BTW, I notice that test_pg_dump's Makefile misquotes its own path name,
probably copy-paste sloppiness.)
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Ashutosh Bapat | 2016-09-08 17:11:01 | Re: Aggregate Push Down - Performing aggregation on foreign server |
Previous Message | Pavan Deolasee | 2016-09-08 16:51:31 | Re: Vacuum: allow usage of more than 1GB of work mem |