Re: missing $PostgreSQL:$

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: missing $PostgreSQL:$
Date: 2008-05-17 02:12:40
Message-ID: 18004.1210990360@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Tom Lane wrote:
>> Yeah, that list looks reasonably sane. The main thing I was worried
>> about was not plastering PostgreSQL markers on files that are simply
>> imported from an upstream source, like the zic database and the
>> libstemmer files.

> The following files have markers from upstream systems. I'm not sure
> that means we don't want to add $PostgreSQL$ markers, though. Thoughts?

> ./src/port/strlcat.c:/* $OpenBSD: strlcat.c,v 1.13 2005/08/08 08:05:37
> espie Exp $ */
> ./src/backend/port/darwin/system.c: * $FreeBSD:
> src/lib/libc/stdlib/system.c,v 1.6 2000/03/16 02:14:41 jasone Exp $
> ./contrib/pgcrypto/rijndael.h:/* $OpenBSD: rijndael.h,v 1.3
> 2001/05/09 23:01:32 markus Exp $ */

I don't have an objection to putting markers on these files, because
as far as I know we're maintaining them as if they were our own source.
The zic and libstemmer files are different because they are not intended
to be maintained in-house --- we're just gonna download and mass-update
from time to time.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-05-17 02:19:19 Re: libpq object hooks
Previous Message Tom Lane 2008-05-17 01:50:01 Re: [HACKERS] TRUNCATE TABLE with IDENTITY