Re: pgsql: Add alter_generic regression test

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add alter_generic regression test
Date: 2012-09-28 23:31:36
Message-ID: 17751.1348875096@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Add alter_generic regression test
> This makes refactoring of parts of the ALTER command safe(r) because we
> ensure no change in functionality.

The buildfarm doesn't like this patch at all, because it fails to cover
machines without collation support. I also note that you ignored this
comment in parallel_schedule:

# NB: temp.sql does a reconnect which transiently uses 2 connections,
# so keep this parallel group to at most 19 tests

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2012-09-28 23:44:10 pgsql: Remove checks for now long outdated compilers.
Previous Message Alvaro Herrera 2012-09-28 21:39:52 pgsql: Add alter_generic regression test