| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Jan Urbański <wulczer(at)wulczer(dot)org>, pgsql-hackers(at)postgresql(dot)org, Shigeru HANADA <hanada(at)metrosystems(dot)co(dot)jp> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Add foreign data wrapper error code values for SQL/MED. |
| Date: | 2010-12-26 17:17:41 |
| Message-ID: | 17631.1293383861@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Sun, Dec 26, 2010 at 8:03 AM, Jan Urbaski <wulczer(at)wulczer(dot)org> wrote:
>> See
>> https://github.com/wulczer/postgres/commit/44fc42b7708f23483156e4e0e1e321e68b2a7e2d#diff-0
>> for something that maybe could be used as a basis to autogenerate
>> errcodes.sgml and plerrcodes.h.
> Interesting. It looks like this might be even easier with perl.
The reason those files aren't autogenerated already is that at the time,
we had a policy of not requiring perl during a build. Now that that
restriction has gone down the drain, it might be worth thinking about.
> Proposed patch attached. This adds what I believe to be the correct
> incantations to errcodes.sgml and plerrcodes.h, and also corrects a
> typographical error in yesterday's commit which I failed to notice
> while reviewing.
Hmm. Even with the typo fixed, ERRCODE_FDW_UNABLE_TO_CREATE_EXECUTION
seems pretty darn opaque. Is it missing a word? Can we rephrase it so
people will have some idea what it means?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jan Urbański | 2010-12-26 19:14:39 | autogenerating error code lists (was Re: [COMMITTERS] pgsql: Add foreign data wrapper error code values for SQL/MED.) |
| Previous Message | Andrew Dunstan | 2010-12-26 15:37:23 | pgsql: Only build in crashdump support on Windows if there's a working |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-12-26 17:31:37 | C++ keywords in headers (was Re: [GENERAL] #include <funcapi.h>) |
| Previous Message | Pavel Stehule | 2010-12-26 17:09:53 | MULTISET patch |